Re: Custom PK generation

From: Andrus Adamchik (andru..bjectstyle.org)
Date: Wed May 11 2005 - 12:13:44 EDT

Next message: Gentry, Michael \(Contractor\): "RE: Optimistic Locking Bug?"

Previous message: jira-norepl..bjectstyle.org: "[OS-JIRA] Created: (CAY-315) classloader problem in dataport"
In reply to: Cris Daniluk: "Custom PK generation"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On May 10, 2005, at 11:28 PM, Cris Daniluk wrote:

> Currently, the 1.2 modeler says "(currently ignored by all adapters
> except Oracle)" under Custom primary key generation.
>
> Is it just me, or is this no longer true? It seems to behave correctly
> if I use it with other DbAdapters...

It sort of works... I think only DB2PkGenerator.createSequenceString()
doesn't do the right thing (something we can fix of course)...

I have a usual excuse why I haven't fixed that till now... I thought
(and still think) that DbKeyGenerator was somewhat of a hack and the
whole PK generation mechanism can use a better design. And better
design takes time. And I never have time :-)

So a patch that fixes DbKeyGenerator across the board (with some unit
tests) is definitely welcomed...

And here is some random thoughts on the further redesign direction:

http://objectstyle.org/jira/secure/ViewIssue.jspa?key=CAY-314
http://objectstyle.org/jira/secure/ViewIssue.jspa?key=CAY-42

Andrus

Next message: Gentry, Michael \(Contractor\): "RE: Optimistic Locking Bug?"
Previous message: jira-norepl..bjectstyle.org: "[OS-JIRA] Created: (CAY-315) classloader problem in dataport"
In reply to: Cris Daniluk: "Custom PK generation"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2.0.0 : Wed May 11 2005 - 12:13:48 EDT