Re: WOFramework.addLib()

From: Harald Niesche (haral..heco.de)
Date: Sun Aug 17 2003 - 06:00:03 EDT

  • Next message: Paolo Sommaruga: "Unistall WOLips from eclipse"

    Jonathan 'Wolf' Rentzsch wrote:
    > I see in WOFramework.java:
    >
    > public void addLib(FileSet set) {
    > lib.addElement(set);
    > }
    >
    > WOFramework extends WOTask. In WOTask.java I see:
    >
    > public void addLib(FileSet set) {
    > lib.addElement(set);
    > }
    >
    > This looks like an incomplete refactoring. Mind if I kill the excess code
    > in WOFramework? Or am I missing something?

    I'm all in favour of refactoring, but you should probably make sure that
    the member lib is not duplicated, too ...

    Harald



    This archive was generated by hypermail 2.0.0 : Sun Aug 17 2003 - 05:51:45 EDT