Re: r4654 - trunk/woproject/wolips/core/plugins/org.objectstyle.wolips.wodclipse.core/java/org/objectstyle/wolips/wodclipse/core/builder

From: Mike Schrag (mschra..dimension.com)
Date: Mon Nov 19 2007 - 14:01:44 EST

  • Next message: Mike Schrag: "Re: r4654 - trunk/woproject/wolips/core/plugins/org.objectstyle.wolips.wodclipse.core/java/org/objectstyle/wolips/wodclipse/core/builder"

    Still not quite fixed, actually.... But yes, this is the intent. It
    CLAIMS to be running the validator, but it doesn't really seem to be
    doing it. I'll get it fixed tonight.

    ms

    On Nov 19, 2007, at 1:58 PM, Kieran Kelleher wrote:

    > Oh thank you. Does this eliminate the need for this workaround
    > documented here:
    > http://wiki.objectstyle.org/confluence/display/WOL/Sticky+WOD+error+markers+will+not+go+away
    >
    > This is a continuous stumbling block for wolips newbies that I
    > assist from time to time.
    >
    > On Nov 19, 2007, at 11:54 AM, mschra..bjectstyle.org wrote:
    >
    >> Author: mschrag
    >> Date: 2007-11-19 11:54:29 -0500 (Mon, 19 Nov 2007)
    >> New Revision: 4654
    >>
    >> Modified:
    >> trunk/woproject/wolips/core/plugins/
    >> org.objectstyle.wolips.wodclipse.core/java/org/objectstyle/wolips/
    >> wodclipse/core/builder/WodBuilder.java
    >> Log:
    >> Fix "build clean" on WO's -- I think it was not revalidating
    >> everything ... Force clear the validation cache.
    >>
    >> Modified: trunk/woproject/wolips/core/plugins/
    >> org.objectstyle.wolips.wodclipse.core/java/org/objectstyle/wolips/
    >> wodclipse/core/builder/WodBuilder.java
    >> ===================================================================
    >> --- trunk/woproject/wolips/core/plugins/
    >> org.objectstyle.wolips.wodclipse.core/java/org/objectstyle/wolips/
    >> wodclipse/core/builder/WodBuilder.java 2007-11-19 14:36:33 UTC (rev
    >> 4653)
    >> +++ trunk/woproject/wolips/core/plugins/
    >> org.objectstyle.wolips.wodclipse.core/java/org/objectstyle/wolips/
    >> wodclipse/core/builder/WodBuilder.java 2007-11-19 16:54:29 UTC (rev
    >> 4654)
    >>.. -152,9 +152,6 @@
    >> Set<IContainer> builtComponents =
    >> componentBuildCache(buildCache);
    >> IContainer woFolder = resource.getParent();
    >> if (!builtComponents.contains(woFolder)) {
    >> - if (_buildKind ==
    >> IncrementalProjectBuilder.FULL_BUILD) {
    >> - file.touch(monitor);
    >> - }
    >> validate = true;
    >> builtComponents.add(woFolder);
    >> }
    >>.. -163,9 +160,6 @@
    >> Set<IContainer> builtComponents =
    >> componentBuildCache(buildCache);
    >> IContainer woFolder = resource.getParent();
    >> if (!builtComponents.contains(woFolder)) {
    >> - if (_buildKind ==
    >> IncrementalProjectBuilder.FULL_BUILD) {
    >> - file.touch(monitor);
    >> - }
    >> validate = true;
    >> builtComponents.add(woFolder);
    >> }
    >>.. -211,15 +205,16 @@
    >> }
    >>
    >> protected void validateWodFile(IFile file, IProgressMonitor
    >> progressMonitor) throws CoreException, LocateException {
    >> - String _resourceName = file.getName();
    >> + String resourceName = file.getName();
    >> if (progressMonitor != null) {
    >> - progressMonitor.subTask("Locating components for " +
    >> _resourceName + " ...");
    >> + progressMonitor.subTask("Locating components for " +
    >> resourceName + " ...");
    >> }
    >> WodParserCache cache = WodParserCache.parser(file);
    >> if (progressMonitor != null) {
    >> progressMonitor.subTask("Building WO " +
    >> cache.getWodFile().getName() + " ...");
    >> }
    >> try {
    >> + cache.clearValidationCache();
    >> cache.parseHtmlAndWodIfNecessary();
    >> cache.validate();
    >> }
    >>
    >



    This archive was generated by hypermail 2.0.0 : Mon Nov 19 2007 - 14:03:20 EST