[OS-JIRA] Created: (WOL-990) Recent FrameworkSet.java modification is buggy

From: Jephte CLAIN (JIRA) ("Jephte)
Date: Tue Apr 07 2009 - 13:37:17 EDT

  • Next message: Jephte CLAIN: "Re: [PATCH] Support"

    Recent FrameworkSet.java modification is buggy
    ----------------------------------------------

                     Key: WOL-990
                     URL: http://issues.objectstyle.org/jira/browse/WOL-990
                 Project: WOProject/WOLips
              Issue Type: Bug
              Components: woproject
        Affects Versions: 2.0.0.4118
                Reporter: Jephte CLAIN
             Attachments: frameworkSet.patch

    FrameworkSet.java was recently modified twice to support the dir attribute. But neither of these changes make use of the facilities provided by ExternalFolderFramework (they actually duplicate poorly some of the logic of ExternalFolderFramework). In fact, one can write instead.

      ExternalFolderFramework framework = new ExternalFolderFramework(
        getFrameworkRoot(),
        new File(getDir(), includedFrameworkFolderName));
      frameworks.add(framework);

    Plus, it solves somes problems with strange corner cases. The patch is attached below.

    -- 
    This message is automatically generated by JIRA.
    -
    If you think it was sent incorrectly contact one of the administrators: http://issues.objectstyle.org/jira/secure/Administrators.jspa
    -
    For more information on JIRA, see: http://www.atlassian.com/software/jira
    



    This archive was generated by hypermail 2.0.0 : Tue Apr 07 2009 - 13:38:16 EDT