Re: r5863 - in branches/eclipse_3_5/wolips/apple/plugins/org.objectstyle.wolips.apple.mavenintegration: META-INF java/org/objectstyle/wolips/apple/mavenintegration/wizards

From: Henrique Prange (hprang..mail.com)
Date: Sun Jul 12 2009 - 16:40:17 EDT

  • Next message: Martino Limido: "Eclipse 3.5 - Slow Build Time"

    Mike,

    IMHO, we should remove or at least disable this plug-in from the build
    process. The current implementation adds no value to Maven 2 users.
    Also, this plug-in is based on m2eclipse and the m2eclipse extension API
    has been changing a lot recently.

    Cheers,

    Henrique

    On 7/12/09 10:21 AM, mschra..bjectstyle.org wrote:
    > Author: mschrag
    > Date: 2009-07-12 09:21:05 -0400 (Sun, 12 Jul 2009)
    > New Revision: 5863
    >
    > Modified:
    > branches/eclipse_3_5/wolips/apple/plugins/org.objectstyle.wolips.apple.mavenintegration/META-INF/MANIFEST.MF
    > branches/eclipse_3_5/wolips/apple/plugins/org.objectstyle.wolips.apple.mavenintegration/java/org/objectstyle/wolips/apple/mavenintegration/wizards/WOMavenApplicationProjectWizard.java
    > branches/eclipse_3_5/wolips/apple/plugins/org.objectstyle.wolips.apple.mavenintegration/java/org/objectstyle/wolips/apple/mavenintegration/wizards/WOMavenFrameworkProjectWizard.java
    > Log:
    > do we even need to keep this plugin around anymore? fixes for the WOLipsNatureUtils stuff
    >
    > Modified: branches/eclipse_3_5/wolips/apple/plugins/org.objectstyle.wolips.apple.mavenintegration/META-INF/MANIFEST.MF
    > ===================================================================
    > --- branches/eclipse_3_5/wolips/apple/plugins/org.objectstyle.wolips.apple.mavenintegration/META-INF/MANIFEST.MF 2009-07-12 12:44:54 UTC (rev 5862)
    > +++ branches/eclipse_3_5/wolips/apple/plugins/org.objectstyle.wolips.apple.mavenintegration/META-INF/MANIFEST.MF 2009-07-12 13:21:05 UTC (rev 5863)
    >.. -16,6 +16,7 @@
    > org.eclipse.ui.ide,
    > org.objectstyle.wolips.locate,
    > org.maven.ide.components.maven_embedder;bundle-version="2.1.0",
    > - org.maven.ide.eclipse;bundle-version="0.9.6"
    > + org.maven.ide.eclipse;bundle-version="0.9.6",
    > + org.objectstyle.wolips.baseforplugins;bundle-version="1.0.6"
    > Bundle-ActivationPolicy: lazy
    > Import-Package: org.maven.ide.eclipse.jdt
    >
    > Modified: branches/eclipse_3_5/wolips/apple/plugins/org.objectstyle.wolips.apple.mavenintegration/java/org/objectstyle/wolips/apple/mavenintegration/wizards/WOMavenApplicationProjectWizard.java
    > ===================================================================
    > --- branches/eclipse_3_5/wolips/apple/plugins/org.objectstyle.wolips.apple.mavenintegration/java/org/objectstyle/wolips/apple/mavenintegration/wizards/WOMavenApplicationProjectWizard.java 2009-07-12 12:44:54 UTC (rev 5862)
    > +++ branches/eclipse_3_5/wolips/apple/plugins/org.objectstyle.wolips.apple.mavenintegration/java/org/objectstyle/wolips/apple/mavenintegration/wizards/WOMavenApplicationProjectWizard.java 2009-07-12 13:21:05 UTC (rev 5863)
    >.. -88,7 +88,7 @@
    > import org.maven.ide.eclipse.core.IMavenConstants;
    > import org.maven.ide.eclipse.jdt.BuildPathManager;
    > import org.objectstyle.wolips.apple.util.StatusLogger;
    > -import org.objectstyle.wolips.core.resources.internal.build.Nature;
    > +import org.objectstyle.wolips.baseforplugins.util.WOLipsNatureUtils;
    > import org.objectstyle.wolips.templateengine.TemplateDefinition;
    > import org.objectstyle.wolips.templateengine.TemplateEngine;
    > import org.objectstyle.wolips.wizards.Messages;
    >.. -217,7 +217,7 @@
    > static boolean addWOLipsNatureToProject(IProject project, IProgressMonitor progressMonitor) {
    > boolean success = false;
    > try {
    > - success = Nature.addIncrementalApplicationNatureToProject(project, progressMonitor);
    > + success = WOLipsNatureUtils.addIncrementalApplicationNatureToProject(project, progressMonitor);
    > } catch (CoreException e) {
    > // FIXME: post appropriate error dialog here -dlee
    > StatusLogger.getLogger().log(new IllegalStateException("Failed to add build natures to project"));
    >
    > Modified: branches/eclipse_3_5/wolips/apple/plugins/org.objectstyle.wolips.apple.mavenintegration/java/org/objectstyle/wolips/apple/mavenintegration/wizards/WOMavenFrameworkProjectWizard.java
    > ===================================================================
    > --- branches/eclipse_3_5/wolips/apple/plugins/org.objectstyle.wolips.apple.mavenintegration/java/org/objectstyle/wolips/apple/mavenintegration/wizards/WOMavenFrameworkProjectWizard.java 2009-07-12 12:44:54 UTC (rev 5862)
    > +++ branches/eclipse_3_5/wolips/apple/plugins/org.objectstyle.wolips.apple.mavenintegration/java/org/objectstyle/wolips/apple/mavenintegration/wizards/WOMavenFrameworkProjectWizard.java 2009-07-12 13:21:05 UTC (rev 5863)
    >.. -88,7 +88,7 @@
    > import org.maven.ide.eclipse.core.IMavenConstants;
    > import org.maven.ide.eclipse.jdt.BuildPathManager;
    > import org.objectstyle.wolips.apple.util.StatusLogger;
    > -import org.objectstyle.wolips.core.resources.internal.build.Nature;
    > +import org.objectstyle.wolips.baseforplugins.util.WOLipsNatureUtils;
    > import org.objectstyle.wolips.templateengine.TemplateDefinition;
    > import org.objectstyle.wolips.templateengine.TemplateEngine;
    > import org.objectstyle.wolips.wizards.Messages;
    >.. -212,7 +212,7 @@
    > static boolean addWOLipsNatureToProject(IProject project, IProgressMonitor progressMonitor) {
    > boolean success = false;
    > try {
    > - success = Nature.addIncrementalApplicationNatureToProject(project, progressMonitor);
    > + success = WOLipsNatureUtils.addIncrementalApplicationNatureToProject(project, progressMonitor);
    > } catch (CoreException e) {
    > StatusLogger.getLogger().log(new IllegalStateException("Failed to to finish project creation", e));
    > }
    >



    This archive was generated by hypermail 2.0.0 : Sun Jul 12 2009 - 16:41:27 EDT