Re: r5961 - branches/eclipse_3_5/wolips/core/plugins/org.objectstyle.wolips.eomodeler/java/org/objectstyle/wolips/eomodeler/utils

From: David Avendasora (webobject..vendasora.com)
Date: Wed Sep 02 2009 - 09:17:47 EDT

  • Next message: Andrew R. Kinnie: "Re: r5961 - branches/eclipse_3_5/wolips/core/plugins/org.objectstyle.wolips.eomodeler/java/org/objectstyle/wolips/eomodeler/utils"

    This is so cool.

    Original bug (WOL-1072) is posted to JIRA at 8:01, it is fixed by 8:12
    and a new build is available (http://webobjects.mdimension.com/hudson/job/WOLipsEclipse35/36/
    ) at 8:16!

    While I know we can't expect 15-minute turn-around for bug fixes on a
    regular basis, this kinds of responsiveness is truly amazing! Makes me
    love being a WO dev.

    Dave

    On Sep 2, 2009, at 8:12 AM, mschra..bjectstyle.org wrote:

    > Author: mschrag
    > Date: 2009-09-02 08:11:57 -0400 (Wed, 02 Sep 2009)
    > New Revision: 5961
    >
    > Modified:
    > branches/eclipse_3_5/wolips/core/plugins/
    > org.objectstyle.wolips.eomodeler/java/org/objectstyle/wolips/
    > eomodeler/utils/TablePropertyViewerSorter.java
    > Log:
    > WOL-1072 Setting shared objects in Entity Modeler fails
    > Accidentally casting the original object instead of the comparison
    > values
    >
    > Modified: branches/eclipse_3_5/wolips/core/plugins/
    > org.objectstyle.wolips.eomodeler/java/org/objectstyle/wolips/
    > eomodeler/utils/TablePropertyViewerSorter.java
    > ===================================================================
    > --- branches/eclipse_3_5/wolips/core/plugins/
    > org.objectstyle.wolips.eomodeler/java/org/objectstyle/wolips/
    > eomodeler/utils/TablePropertyViewerSorter.java 2009-09-02 03:46:21
    > UTC (rev 5960)
    > +++ branches/eclipse_3_5/wolips/core/plugins/
    > org.objectstyle.wolips.eomodeler/java/org/objectstyle/wolips/
    > eomodeler/utils/TablePropertyViewerSorter.java 2009-09-02 12:11:57
    > UTC (rev 5961)
    >.. -119,8 +119,8 @@
    > } else if (o2 == null) {
    > comparison = 1;
    > } else if (o1 instanceof Boolean && o2 instanceof Boolean) {
    > - boolean left = ((Boolean) _o1).booleanValue();
    > - boolean right = ((Boolean) _o2).booleanValue();
    > + boolean left = ((Boolean) o1).booleanValue();
    > + boolean right = ((Boolean) o2).booleanValue();
    > if (left == right) {
    > comparison = 0;
    > } else if (left == true) {
    >
    >
    >



    This archive was generated by hypermail 2.0.0 : Wed Sep 02 2009 - 09:41:11 EDT