[OS-JIRA] Created: (WOL-1078) Problems during reverse engineering aren't reported to the user

From: Mark Ritchie (JIRA) ("Mark)
Date: Wed Sep 09 2009 - 00:25:59 EDT

  • Next message: Mark Ritchie (JIRA): "[OS-JIRA] Created: (WOL-1079) URLUtils.cheatAndTurnIntoFile(URL url) doesn't handle URLs which are not encoded. This breaks reverse engineering."

    Problems during reverse engineering aren't reported to the user
    ---------------------------------------------------------------

                     Key: WOL-1078
                     URL: http://issues.objectstyle.org/jira/browse/WOL-1078
                 Project: WOProject/WOLips
              Issue Type: Improvement
              Components: wolips
        Affects Versions: WOLips 3.3.* Next Stable Build
             Environment: OSX 10.5.7, java 1.5, Eclipse 3.4.2, WOLips top of tree.
                Reporter: Mark Ritchie

    Mike's code to fix the problem is here in this patch:

    Index: wolips/core/plugins/org.objectstyle.wolips.eomodeler/java/org/objectstyle/wolips/eomodeler/actions/ReverseEngineerAction.java
    ===================================================================
    --- wolips/core/plugins/org.objectstyle.wolips.eomodeler/java/org/objectstyle/wolips/eomodeler/actions/ReverseEngineerAction.java (revision 5973)
    +++ wolips/core/plugins/org.objectstyle.wolips.eomodeler/java/org/objectstyle/wolips/eomodeler/actions/ReverseEngineerAction.java (working copy)
    ..-53,6 +53,7 @@
     import java.util.Arrays;
     import java.util.HashSet;
     import java.util.List;
    +import java.util.Set;
     
     import org.eclipse.jface.action.IAction;
     import org.eclipse.jface.dialogs.MessageDialog;
    ..-75,6 +76,7 @@
     import org.objectstyle.wolips.eomodeler.core.sql.IEOSQLReverseEngineer;
     import org.objectstyle.wolips.eomodeler.core.sql.IEOSQLReverseEngineerFactory;
     import org.objectstyle.wolips.eomodeler.core.utils.EOModelUtils;
    +import org.objectstyle.wolips.eomodeler.editors.EOModelErrorDialog;
     import org.objectstyle.wolips.eomodeler.utils.StringLabelProvider;
     
     public class ReverseEngineerAction implements IWorkbenchWindowActionDelegate, IObjectActionDelegate {
    ..-120,7 +122,12 @@
                                             System.arraycopy(selectedTableNameObjs, 0, selectedTableNames, 0, selectedTableNameObjs.length);
                                             List<String> selectedTableNamesList = Arrays.asList(selectedTableNames);
                                             File reverseEngineeredEOModelFolder = reverseEngineer.reverseEngineerWithTableNamesIntoModel(selectedTableNamesList);
    - model.importEntitiesFromModel(reverseEngineeredEOModelFolder.toURL(), new HashSet<EOModelVerificationFailure>());
    + Set<EOModelVerificationFailure> failures = new HashSet<EOModelVerificationFailure>();
    + model.importEntitiesFromModel(reverseEngineeredEOModelFolder.toURL(), failures);
    + if (failures.size() > 0) {
    + EOModelErrorDialog dialog = new EOModelErrorDialog(_window.getShell(), failures);
    + dialog.open();
    + }
                                             model.setReverseEngineered(true);
                                     }
                             } 

    -- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.objectstyle.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

    This archive was generated by hypermail 2.0.0 : Wed Sep 09 2009 - 00:26:47 EDT